[PATCH] TARGET_ADJUST_BREAKPOINT_ADDRESS - patch 4 of 4
Michael Snyder
msnyder@redhat.com
Tue Oct 14 20:23:00 GMT 2003
Kevin Buettner wrote:
> On Oct 7, 4:00pm, Michael Snyder wrote:
>
>>Maybe "bpaddr - 4" could also be "bpaddr - sizeof (something)".
>
>
> I hear alarm bells go off in my head whenever I see sizeof() used in
> target specific code. (Sometimes it's perfectly okay, but I hear them
> just the same.) So, what I've done instead is to define
> ``frv_instr_size'' and use that constant instead of 4 in
> frv_gdbarch_adjust_breakpoint_address().
That's kinda what I meant. "sizeof" was a concept, not an operator. ;-)
Thanks for the tweaks.
More information about the Gdb-patches
mailing list