[commit] Deprecate remaining STREQ uses

Kevin Buettner kevinb@redhat.com
Tue Nov 25 00:09:00 GMT 2003


On Nov 24,  3:03pm, Andrew Cagney wrote:

> > IMO, it should be possible to convert uses of STREQ/STREQN without
> > much risk.
> 
> To speak from experience, I found 'n' fixed errors in even the existing 
> conversions.  You'll note that some of the mamoth conversions that 
> you've done in the past also had similar problems.

True.  I do recall having to fix problems in the code prior to starting
a conversion.

> Anyway, Eli's pointed me at an automated tool for finishing the task.

Automated tools are good.  (I figured you already had most of it
automated...)

Even if the process isn't entirely automated, it's still sometimes
better to do the conversion all at once.  By deprecating something,
you're forcing someone else (or even a later version of yourself) to
deal with the problem later on.  Chances are good that the person
making the changes understand the issues surrounding the change a lot
better than someone coming at it cold later on.  Also, doing it all at
once will (hopefully) ensure that the changes in question are done in
a uniform manner.

Kevin



More information about the Gdb-patches mailing list