[commit] Order parameters "rw", not "wr"

Daniel Jacobowitz drow@mvista.com
Thu Nov 13 16:39:00 GMT 2003


On Thu, Nov 13, 2003 at 11:35:56AM -0500, Andrew Cagney wrote:
> 
> >>O_RDWR Open for reading and writing
> >>S_IRWXU 00700 user (file owner) has read, write and execute permission
> >>drwxr-xr-x    2 cagney   cagney       8192 Nov 11 13:52 bin
> >
> >
> >Those aren't arguments, just a couple occurances of "read, write", so I
> >fail to see the connection.  Consider memcpy, strcat, fgets, sprintf. 
> 
> What you list here have little if any relevance to the interfaces in 
> question.

There are, as far as I know, no examples of functions in the standard
library which take an output buffer last.  As much of a C convention as
there is suggests they belong at the beginning.

If you're going to ignore that very weak precedent, that's your
perogative, go right ahead.  But please don't claim that "O_RDWR" is in
any way relevant to the argument ordering on target_xfer_partial
either.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer



More information about the Gdb-patches mailing list