[commit] Fix two xfer partial bugs; Was; RFA: ia64 portion of libunwind patch

J. Johnston jjohnstn@redhat.com
Thu Nov 6 20:12:00 GMT 2003



Andrew Cagney wrote:
> Jeff,
> 
> I've just committed the attached.  It fixes two bugs when using xfer 
> partial in an existing target.
> 
> - the "add_target" method was always overriding the child's 
> to_xfer_partial method.  The consequence is that the code your patch 
> adds is never called!
> 
> - the code would all off the end of a stack which this part of the 
> change fixed: * target.c (init_dummy_target): Initialize to_xfer_partial 
> to default.
> 
> I've one more tweak to the target code.  Once thats in can you please 
> confirm that this new child method is called and is needed - seems 
> things work without it?
> 

Yes.  It is only called if the find_pc_in_section() call fails which it doesn't 
for the gdb testsuite.

I can try hardwiring a failure to verify that code works once you have your 
changes in.

-- Jeff J.





More information about the Gdb-patches mailing list