[PATCH/RFC] coffread.c: delete param

Elena Zannoni ezannoni@redhat.com
Wed Nov 5 15:30:00 GMT 2003


Elena Zannoni writes:
 > 
 > Based on the discussion in this thread:
 > http://sources.redhat.com/ml/gdb-patches/2003-10/msg00405.html
 > 
 > I don't have a set up to test this, though. It does build, that's all
 > I can say.
 > 
 > [Richard, Nick, this does affect arm-coff]
 > 
 > elena
 > 

committed.

elena

 > 2003-10-14  Elena Zannoni  <ezannoni@redhat.com>
 > 
 > 	* coffread.c (coff_symtab_read): Remove passing of info parameter
 > 	to prim_record_minimal_symbol_and_info.
 > 
 > Index: coffread.c
 > ===================================================================
 > RCS file: /cvs/uberbaum/gdb/coffread.c,v
 > retrieving revision 1.45
 > diff -u -p -r1.45 coffread.c
 > --- coffread.c	21 Sep 2003 01:26:44 -0000	1.45
 > +++ coffread.c	14 Oct 2003 21:37:31 -0000
 > @@ -926,15 +926,8 @@ coff_symtab_read (long symtab_offset, un
 >  	    if (cs->c_name[0] != '@' /* Skip tdesc symbols */ )
 >  	      {
 >  		struct minimal_symbol *msym;
 > -
 > - 		/* FIXME: cagney/2001-02-01: The nasty (int) -> (long)
 > -                   -> (void*) cast is to ensure that that the value of
 > -                   cs->c_sclass can be correctly stored in a void
 > -                   pointer in MSYMBOL_INFO.  Better solutions
 > -                   welcome. */
 > -		gdb_assert (sizeof (void *) >= sizeof (cs->c_sclass));
 >  		msym = prim_record_minimal_symbol_and_info
 > -		  (cs->c_name, tmpaddr, ms_type, (void *) (long) cs->c_sclass,
 > +		  (cs->c_name, tmpaddr, ms_type, NULL,
 >  		   sec, NULL, objfile);
 >  		if (msym)
 >  		  COFF_MAKE_MSYMBOL_SPECIAL (cs->c_sclass, msym);



More information about the Gdb-patches mailing list