[commit] Don't call deprecated_inside_entry_file from ...id_unwind()

Daniel Jacobowitz drow@mvista.com
Sat Nov 1 00:44:00 GMT 2003


On Fri, Oct 31, 2003 at 07:00:09PM -0500, Andrew Cagney wrote:
> Hello,
> 
> Sometime ago, while developing the frame unwind code using the d10v, I 
> added an innocent looking hack that stopped the d10v falling off the end 
> of its stack:
> 
> -  /* This is meant to halt the backtrace at "_start".  Make sure we
> -     don't halt it at a generic dummy frame.  */
> -  if (func <= IMEM_START || inside_entry_file (func))
> -    return;
> 
> That logic being lifed from even older frame chain code.
> 
> I then later fixed the underlying problem (inside_main_func was broken), 
> but forgot to remove that hack.
> 
> Oops!
> 
> That innocent looking code as quitely spread to at least 4 other 
> architectures (there was no comment saying "hey you don't need this").
> 
> Anyway, the attached patch removes all occurance of the hack.

Are you certain that none of those other architectures needed the hack
anyway?

Also, snce GDB does support backtracing when main isn't even in the
equation, I don't think we should break that unless the check is
actually harmful.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer



More information about the Gdb-patches mailing list