RFC: coffread.c relocation fixes

[Raoul Gough]

"Elena Zannoni" <ezannoni@redhat.com> wrote in message
news:16078.19295.731449.579816@localhost.redhat.com...
> Raoul Gough writes:
[snip]
>  > I've added the script as a note to PR 1132 in GNATS (see
>  > http://sources.redhat.com/ml/gdb-prs/2003-q2/msg00129.html).
>  >
>
> I don't have much comments on the test (except that the convention
is
> to use '-' instead of '_' in file names, and that you need to update
> the gdb/config/djgpp/fnchange.lst file). I wonder if instead of
'while 1'
> you could use exp_continue. MichaelC?

Oh, DOS 8.3 filenames - I see... probably best to rename the files
everywhere - otherwise the shared-reloc.exp script would have to be
aware of the renaming issue on DJGPP (since it invokes the compiler on
the long-named .c files). I've attached the new versions to this post.
BTW, I think Andrew Cagney is sorting out CVS access for me, so I may
be able to add the test to CVS myself, if that's appropriate. I wonder
if this test works on DJGPP?

Regarding the "while 1" issue - my TCL/expect skills are so minimal, I
couldn't think of a better way of doing the loop - an improvement
would be good, as long as it doesn't involve me learning any more TCL
:-)

>  > I've attached an updated diff to this posting with a fix for the
typo
>  > that Elena identified. Any advice on getting these patches
checked in
>  > and the PR closed? I can't do it myself, since I don't have any
write
>  > access.
>  >
>
> I can commit it for you.

Thanks for this - the latest CVS version now passes the shared object
relocation tests.

Regards,
Raoul Gough.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: shreloc.c
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20030528/56dca6ff/attachment.c>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: shreloc2.c
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20030528/56dca6ff/attachment-0001.c>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: shreloc1.c
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20030528/56dca6ff/attachment-0002.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shreloc.exp
Type: application/octet-stream
Size: 6904 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20030528/56dca6ff/attachment.obj>