PATCH: Use $(SHELL) when running mkinstalldirs

Andrew Cagney ac131313@redhat.com
Wed May 14 12:51:00 GMT 2003


I"m guessing that this is an [RFA], rather than a [commit].  Yes, ok.

BTW, Makefile and configure go under the loosely defined comment ``do 
you feel lucky?''.  There is no one explicitly responsible for this 
section of GDB.  Instead it's left to peoples judgment (typically the 
only way to test this is to commit it) - post one day, commit one or few 
later (or earlier if its pretty obvious :-).

Andrew



> A GNU Makefile should always use $(SHELL) when running a shell
> script.  The gdb Makefile.in fails to do this when running
> mkinstalldirs in the install-only target, although it does do it in
> other places.
> 
> Here is a patch.
> 
> Ian
> 
> 2003-05-13  Ian Lance Taylor  <ian@airs.com>
> 
> 	* Makefile.in (install-only): Use $(SHELL) when running
> 	mkinstalldirs.
> 
> 
> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/Makefile.in,v
> retrieving revision 1.375
> diff -u -r1.375 Makefile.in
> --- Makefile.in	12 May 2003 00:26:18 -0000	1.375
> +++ Makefile.in	14 May 2003 06:14:21 -0000
> @@ -935,10 +935,10 @@
>  		else \
>  		  true ; \
>  		fi ; \
> -		$(srcdir)/../mkinstalldirs $(bindir) ; \
> +		$(SHELL) $(srcdir)/../mkinstalldirs $(bindir) ; \
>  		$(INSTALL_PROGRAM) gdb$(EXEEXT) \
>  			$(DESTDIR)$(bindir)/$$transformed_name$(EXEEXT) ; \
> -		$(srcdir)/../mkinstalldirs \
> +		$(SHELL) $(srcdir)/../mkinstalldirs \
>  			$(DESTDIR)$(man1dir) ; \
>  		$(INSTALL_DATA) $(srcdir)/gdb.1 \
>  			$(DESTDIR)$(man1dir)/$$transformed_name.1
> 




More information about the Gdb-patches mailing list