[patch rfc] Dummy deprecate deluge

[Andrew Cagney]

Hello,

This deprecates all but one of the now defunct dummy methods.  I need to 
investigate call_dummy_address to see if it two is no longer needed.

One, REGISTER_SIZE deserves a few comments.

In infcall.c, the dummy frame code uses REGISTER_SIZE to figure out how 
to convert the dummy frame words from host to target byte order:

   /* CALL_DUMMY is an array of words (REGISTER_SIZE), but each word is
      in host byte order.  Before calling FIX_CALL_DUMMY, we byteswap
      it and remove any extra bytes which might exist because ULONGEST
      is bigger than REGISTER_SIZE.  */
   /* NOTE: This is pretty wierd, as the call dummy is actually a
      sequence of instructions.  But CISC machines will have to pack
      the instructions into REGISTER_SIZE units (and so will RISC
      machines for which INSTRUCTION_SIZE is not REGISTER_SIZE).  */
   /* NOTE: This is pretty stupid.  CALL_DUMMY should be in strict
      target byte order. */

The whole dummy mess is replaced by push_dummy_code().  I also found 
mi/mi-main.c:

   /* Get the value into an array */
   buffer = xmalloc (REGISTER_SIZE);
   old_chain = make_cleanup (xfree, buffer);
   store_signed_integer (buffer, REGISTER_SIZE, value);
   /* Write it down */
   deprecated_write_register_bytes (REGISTER_BYTE (regnum), buffer, REGIS
TER_RAW_SIZE (regnum));

I'm not sure what this one is smoking, it suspect that it should have 
used REGISTER_RAW_SIZE().

I'll look to commit it in a few days (then fix the above bug),
Andrew
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diffs
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20030504/bcdc2fcb/attachment.ksh>