RFA: dbxread patch

[J. Johnston]

Jim Blandy wrote:
> Yes, looks good.
> 
> Please add a comment briefly explaining why the check is needed
> (hand-generated stabs that contain N_FUN stabs but no N_SLINE stabs).
> 

I have attached a new patch with a comment.

> Elena suggested the change, right?  She should be credited in the
> ChangeLog entry.
> 

You are correct - thanks for spotting this oversight.

2003-02-25  Jeff Johnston  <jjohnstn@redhat.com>

	From Elena Zannoni  <ezannoni@redhat.com>
	* dbxread.c (process_one_symbol): Only record line 0 if one or more sline
	entries have been seen for the function.


Ok now?

-- Jeff J.

> "J. Johnston" <jjohnstn@redhat.com> writes:
> 
> 
>>The following patch fixes a problem when the stabs debug info
>>for a file does not contain sline entries.  This happens, for
>>example with the glibc syscall code which is generated assembler
>>code.  In process_one_symbol in dbxread.c, a line 0 is recorded for the
>>end of the function.  When there are no other line numbers, we end up finding this
>>line 0 as our alt_symtab in symtab:find_pc_sect_line() and we end up
>>subtracting one resulting in line -1.  This problem manifests itself
>>when we attempt to break at the generated glibc functions such as
>>kill.
>>
>>The patch changes process_one_symbol() to only record line 0 if sline info
>>has been found for the function.
>>
>>Ok to commit?
>>
>>-- Jeff J.
>>
>>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dbxread.patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20030225/1308d78e/attachment.ksh>