[PATCH] S/390 port modernization 3/4

Andrew Cagney cagney@gnu.org
Fri Dec 5 15:07:00 GMT 2003


Ulrich,

two FYIs
> ! 	else
> ! 	  abort ();
>         }

GDB doesn't call abort (well ok, there's one call :-) Instead for cases 
like this GDB should call internal_error.

> ! 	case RETURN_VALUE_STRUCT_CONVENTION:
> ! 	  error ("Cannot set function return value.");
> ! 	  break;

If this happens, GDB's shot itself in the foot so might as well call 
internal_error here as well.

Jim, since you're handling this, can I assume that you'll clean up any 
nuences that the ARI identifies (as I did for the last round of s390 
patches).  It will save Ulrich the need of respining what are basicly 
correct patches.

Andrew




More information about the Gdb-patches mailing list