[RFC]: pending break support

J. Johnston jjohnstn@redhat.com
Thu Dec 4 16:56:00 GMT 2003



Eli Zaretskii wrote:
>>Date: Wed, 03 Dec 2003 14:46:49 -0500
>>From: "J. Johnston" <jjohnstn@redhat.com>
>>
>>How about the following updated patch?  I tied together why I was talking about
>>the various operations on pending breakpoints which makes the grouping of the
>>information make more sense.
> 
> 
> Okay.  I'm down to nit-picking now:
> 

No problem.

> 
>>+If a specified breakpoint location cannot be found, you will be prompted
>>+as to whether you want to make the breakpoint pending on a future shared
> 
> 
> I'd replace "you will be prompted" with "@value{GDBN} will prompt
> you".  Native English speakers keep telling me that using passive
> forms is BAD.
>

Ok.

> 
>>+Normal breakpoint operations apply to pending breakpoints as well.  You may 
>>+specify, a condition for a pending breakpoint, commands to run when the 
> 
>           ^
> The comma I marked should not be there, I think.
> 

I put the comma because you can specify a condition and you can specify 
commands.  Without it, the next part of the sentence doesn't make sense.  I 
didn't want to reuse specify as that made the sentence feel redundant.  I think 
maybe the best idea would be to use "or" instead of the commas.

How about:

Normal breakpoint operations apply to pending breakpoints as well.  You may 
specify a condition for a pending breakpoint and/or commands to run when the 
breakpoint is reached.  You can also enable or disable the pending breakpoint.
...
> 

-- Jeff J.



More information about the Gdb-patches mailing list