RFC (gdb/mi): -stack-list-locals + PATCH
Tue Dec 2 03:14:00 GMT 2003
> > I don't really know what make_cleanup_ui_out_tuple_begin_end and do_cleanups
> > do and I've approximated a simple data type to something that isn't
> > TYPE_CODE_ARRAY or TYPE_CODE_STRUCT so it's probably a pretty gross hack.
> > The idea is that the user can see the value of simple data types immediately
> > and can create variable objects for complex data types if he wishes to explore
> > their values in more detail.
> > Any comments?
> Looks like its time to cleanup "values" changing it to an enum or
> bitmask - too many magic numbers.
I see now that I've also inadvertantly defined "-stack-list-arguments 2". I don't
know what magic numbers are but clearly better structure is desirable.
> Would is_integral_type() give you what you want?
For a simple data type? I don't think so. What about float? Perhaps I'm missing
> For the cleanups try the restructured form:
> struct cleanup = cleanups = make_cleanup (NULL, null_cleanup);
> do_cleanups (cleanups);
> make_cleanup_ui_out_tuple_begin_end opens the tuple and then closes it
> via a cleanup (if an error is thrown the tuple under construction is
> still finished).
I understand make_cleanup_ui_out_tuple_begin_end but not the above
restructured form. Do I have to call make_cleanup (or relatives) each time I
allocated memory i.e for each call to ui_out_field_stream?
While I'm thinking about the above, here is a basic patch for
mi-cmd-stack.c. Currently if -stack-list-locals is invoked then it gives a
segmentation fault (Segmentation fault (core dumped)). This is inconvenient
and the patch changes this to give an output similar to that of cli:
&"No frame selected.\n"
^error,msg="No frame selected."
*** mi-cmd-stack.c.~1.19.~ 2003-06-12 23:29:37.000000000 +0100
--- mi-cmd-stack.c 2003-12-02 02:43:04.000000000 +0000
*** 138,147 ****
--- 138,150 ----
mi_cmd_stack_list_locals (char *command, char **argv, int argc)
if (argc != 1)
error ("mi_cmd_stack_list_locals: Usage: PRINT_VALUES");
+ if (!deprecated_selected_frame)
+ error ("No frame selected.");
list_args_or_locals (1, atoi (argv), deprecated_selected_frame);
More information about the Gdb-patches