[rfa] some -Wformat-nonliteral changes

[David Carlton]

On Mon, 04 Aug 2003 10:05:43 -0400, Andrew Cagney <ac131313@redhat.com> said:

> Insert expression of disbelief:

>> -      internal_error ("Error converting character `%d' from `%s' to `%s' "
>> +      internal_error (__FILE__, __LINE__,
>> +		      "Error converting character `%d' from `%s' to `%s' "
>> "character set: %s",
>> from_char, ci->from->name, ci->to->name,
>> safe_strerror (errno));

We can be pleased at GDB's robustness that this internal error doesn't
get triggered.  :-)

> Yes, ok, and yes, the internal_error patch should go onto the
> branch.

Great; I've committed all of it to mainline, and the internal_error
part to the branch.

> Before reverting -Wformat-nonliteral, I'd like to see exactly what the
> damange is - it's clearly finding bugs.

Okay, but I'll continue to grumble... :-)

David Carlton
carlton@kealia.com