[patch rfc] New file "infcall.c" containing a merged call_function_by_hand
Andrew Cagney
ac131313@redhat.com
Wed Apr 16 17:36:00 GMT 2003
The attached moves _all_ the relevant code to "infrun.[hc]".
Baring comment I'll commit this in a few days,
Andrew
> Hmm,
>
> Let's try a different subject line :-) Any thoughts?
>
> Andrew
>
>
> Subject:
> [patch rfc] Merge call_function_by_hand & run_stack_dummy; move to infcall.c?
> From:
> Andrew Cagney <ac131313@redhat.com>
> Date:
> Wed, 09 Apr 2003 21:08:36 -0400
> To:
> gdb-patches@sources.redhat.com
>
> Hello,
>
> This patch inlines run_stack_dummy into it's only caller - call_function_by_hand (nee hand_function_call). Going by some of the comments, there were once many callers but that is no more.
>
> This opens the way for more cleanup / rationalization of call_function_by_hand. For instance:
>
> - rationalize the computation of the the dummy breakpoint address
>
> - ditto for the dummy entry point
>
> - long term, split this in two; move the code handling the return to a breakpoint callback (just need to add breakpoint callbacks) and thence; make the expression evaluator async
>
> Question is, should this code be moved to a separate file? It's come up before:
> http://sources.redhat.com/ml/gdb/2002-09/msg00485.html
> dummy-frame.c now contains code implementing the `dummy-frame', so infcall.c.
>
> Andrew
>
>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diffs
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20030416/e3e35749/attachment.ksh>
More information about the Gdb-patches
mailing list