[rfc] Only compare against dummy frame's top when explicitly set

Andrew Cagney ac131313@redhat.com
Fri Sep 27 13:25:00 GMT 2002


Hello,

To follow up an earlier thread, the attached revised patch modifies 
generic_find_dummy_frame() so that it only tests TOP when it was set.
However, this time it uses the value of TOP instead of 
find_dummy_frame_p().  I think this is more robust since, as with the 
ia64, it allows an architecture to explicitly set TOS (rather than rely 
on hand_function_call() to set it).

I'm intending to commit this in a few days (~monday).  I should note 
that there is evidence that the change, while arguably correct, will 
break something.  cf, the fixes I recently made to the rs6000 because 
the change flushes out bugs in that target that the incorrect test was 
hiding.

Thoughts before the commit?

Andrew
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diffs
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20020927/4272ec6a/attachment.ksh>


More information about the Gdb-patches mailing list