[5.3 PATCH]: Fix TUI breaking gdb interpreters (mi)

Stephane Carrez stcarrez@nerim.fr
Thu Nov 21 13:26:00 GMT 2002


Hi!

Daniel Jacobowitz wrote:
 > Two problems:
 >  TUI broke the MI interface if TUI is enabled at compile time.  The change
 > which did this does was on Sept. 10th, 2002.  There's a typo in the
 > ChangeLog which made it hard to find...
 >
 >        * tui-hooks.c (tui_event_loop): New function.
 >        (tui_command_loop): New function to override gdb loop and make sure
 >        uiout is set according to TUI mode.
 >        (tui_command_loop): Install the specific TUI command hook.
 >
 > (the second tui_command_loop should have been tui_init_hook).
 >
 > You can't just override the command loop that way!  MI does this
 > conditionally on -i=mi being specified.
 >
 > This also breaks the bit at the end of gdb/top.c to handle unknown -i=
 > switches.

Too bad...

I've committed this patch to avoid the TUI initialization when some interpreter
was specified (It does not make sense to enable TUI when there such interpreter).
I also fixed the ChangeLog typo.

gdb -i=mi seems to work after that (at least better than without it).

	Stephane

2002-11-21  Stephane Carrez  <stcarrez@nerim.fr>

	* tui-hooks.c (tui_init_hook): Don't enable the TUI if a specific
	interpreter is installed.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: tui-fixes.diffs
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20021121/b967a9d7/attachment.ksh>


More information about the Gdb-patches mailing list