[RFC/MI] Renumber enum mi_cmd_result

Andrew Cagney ac131313@cygnus.com
Fri May 17 14:43:00 GMT 2002


> Hi,
> 
> I've been looking over Apple's MI changes, so expect to see quite a few
> questions/changes/patches/debates/documentation updates/etc in the coming
> weeks on MI.
> 
> This simple patch renumbers enum mi_cmd_result so that it starts at one
> instead of zero. This is necessary because MI_CMD_DONE would be
> indistinguishable from an error condition (both would return zero to
> catch_errors).
> 
> I have run the testsuite before and after this change, and it produces no
> differences.
> 
> (Okay, this is almost too simple to leave by itself, but, gotta start
> somewhere!)
> 
> Keith
> 
> ChangeLog
> 2002-05-17  Keith Seitz  <keiths@redhat.com>
> 
>         From Jim Ingham <jingham at apple dot com>:
>         * mi-cmds.h (enum mi_cmd_result): Start numbering at one instead
>         of zero so that errors can be distinguished from other status
>         returns.
> 
Keith,

Check catch_exceptions().  The whole catch_errors() argument problem has 
been fixed.  I'd consider a switch to catch_exceptions obvious and I can 
see only one call.

Andrew




More information about the Gdb-patches mailing list