[patch/rfc] Simplify local_hex_string_custom() et.al.
Andrew Cagney
ac131313@cygnus.com
Sat May 4 15:24:00 GMT 2002
Hello,
The attached patch rationalises:
local_hex_string(long )
local_hex_string_custom(long)
longest_local_hex_string(longest)
longest_local_hex_string_custom(longest)
The long/LONGEST variants are merged. The function that does all the
work (local_hex_string_custom() nee longest_local_hex_string_custom())
is stripped of the convoluted #if CC_HAS_LONG_LONG and
PRINTF_HAS_LONG_LONG cases and instead always does the conversion the
hard way.
I figure that at least this way once a bug is fixed it is fixed for all
platforms.
Thoughts? I'll look to be committing this in ~a week.
There are, I think, several good follow-on patches:
local_address_string{,_custom}()
to handle the address case
Get rid of all those if (TARGET_ADDR_BIT) ... else ...
local_{decimal,octal}_string{,_custom}()
so that print_longest() can receive
similar treatment (and always work)
(more tricky) make it possible to print 128 bit numbers.
enjoy,
Andrew
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diffs
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20020504/90e1ed03/attachment.ksh>
More information about the Gdb-patches
mailing list