[5.2.1] quiet warnings for gdbreplay.c
Andrew Cagney
ac131313@ges.redhat.com
Fri Jun 28 14:20:00 GMT 2002
> On Fri, Jun 28, 2002 at 12:12:31PM -0400, Andrew Cagney wrote:
>
>> >+#ifdef HAVE_STRING_H
>> >+#include <string.h>
>> >+#endif
>
>>
>> Should that bit be "gdb_string.h"?
>
>
> That depends :) gdbreplay is not part of GDB and has a different
> config.h header (tests for a different set of macros).
(We could always fix that - eliminate that configure file :-^ )
More seriously, I think someone hacking on gdbreplay is likely to also
be hacking on GDB. Consequently, they are going to expect the two
directories to follow the same coding conventions.
I had
> eliminated all references to the gdb source code but then I introduced
> an include of "gdb_proc_service.h", since the alternative was just
> duplicating it; I have the feeling we should move that and headers like
> gdb_string.h somewhere common - are they include/gdb/ candidates?
You mean #include "gdb/gdb_string.h"? I think include/gdb/ is for
external interfaces that are at some level controlled by GDB.
Andrew
More information about the Gdb-patches
mailing list