[PATCH] m68k multi-arch: frame_saved_regs

Grace Sainsbury graces@redhat.com
Fri Jun 21 08:27:00 GMT 2002


I fixed the ChangeLog and indented m68k-tdep.

the ne ChangeLog:

2002-06-21  Grace Sainsbury  <graces@redhat.com>

	* m68k-tdep.c (m68k_frame_init_saved_regs): Replace
        m68k_find_saved_regs.
        (m68k_pop_frame): Removed saved_regs structure, and replaced
        references to it with frasme->saved_regs.
        (m68k_gdbarch_init): Added function calls to initialize the
        gdbarch structure.
	(m68k_fix_call_dummy): Add. 
	* config/m68k/tm-m68k.h: (FRAME_FIND_SAVED_REGS): Remove.
       	(CALL_DUMMY): Remove.
	(CALL_DUMMY_LENGTH): Remove.
	(CALL_DUMMY_START_OFFSET): Remove.
	(CALL_DUMMY_BREAKPOINT_OFFSET): Remove.
	(FIX_CALL_DUMMY): Remove.
	(PUSH_DUMMY_FRAME): Remove.
	(POP_FRAME): Remove.

is it ok to commit.

grace

On Fri, Jun 21, 2002 at 11:02:57AM -0400, Andrew Cagney wrote:
> Just some tweaks (Eli might have to correct me :-)
> 
> > 2002-06-20  Grace Sainsbury  <graces@redhat.com>
> > 
> >         * m68k-tdep.c (m68k_frame_init_saved_regs): Replaced
> >         m68k_find_saved_regs.
> 
> I think a ChangeLog uses present tense ``Replace m68k...''.
> 
> >         (m68k_pop_frame): Removed saved_regs structure, and replaced
> >         references to it with frasme->saved_regs.
> >         (m68k_gdbarch_init): Added function calls to initialize the
> >         gdbarch structure. 
> >         * config/m68k/tm-m68k.h: Removed FRAME_FIND_SAVED_REGS and
> >         macros associated with CALL_DUMMY
> 
> Remember to provide the complete list.  At some stage in the future 
> someone will be looking at this and wondering exactly which macros they 
> were.  This sometimes leads to very long ChangeLog entries but we live 
> with that :-).  Trailing period.
> 
> * config/.....h (RFRAME)FIND_SAVED_REGS): Remove.
> (CALL_DUMMY): Delete.
> ...
> 
> +m68k_fix_call_dummy(char *dummy, CORE_ADDR pc, CORE_ADDR fun, int nargs,
> 
> Just, suggest running the file through indent (``..._dummy (...'').
> 
> That wacks the hardest ones! ya.
> Andrew
> 
> 



More information about the Gdb-patches mailing list