[RFA] dwarf2cfi.c improvements

[Andrew Cagney]

>   	internal_error (__FILE__, __LINE__,
> ! 			"%s: unknown pointer encoding: 0x%x",
> ! 			__func__, encoding);
>         }

Michael,

Just FYI, __func__ can't be used.  It isn't considered part of the ISO C 
that GDB builds to.

> !     error ("%s: CFA is not defined as CFA_REG_OFFSET", __func__);

Hmm, I don't think user error messages need to include function names.

Can I suggest pulling the error() and internal_error() message changes 
out, cleaning them up, and then committing them separatly.   Better 
messages (eg printing the reason for a bad switch) are always a good idea.

That also has the benefit of trimming your patch back.

enjoy,
Andrew