[PATCH] Remove bogosities from dwarf2cfi.c:cfi_pop_frame()

Richard Earnshaw rearnsha@arm.com
Wed Jul 10 05:22:00 GMT 2002


> > Using alloca() here is pretty obvious.  I discussed the other fix with
> > Michael Ludvig.
> > 
> > Checked in.
> > 
> > Mark
> > 
> > Index: ChangeLog
> > from  Mark Kettenis  <kettenis@gnu.org>
> > 
> > 	* dwarf2cfi.c (cfi_pop_frame): Use alloca() for regbuf.
> > 	Don't call get_current_frame().
> > 
> 
> Heads up,
> 
> I think the write_register_bytes() call should be replaced by 
> regcache_register_write(current_regcache, ).  This is new code so it 
> doesn't need to go through any of that nasty write_register_bytes() stuff.
> 
> Andrew
> 
> 

Why is this code trying to poke directly into the regcache at all?  AFAICT 
it should be operating on the pseudo registers not the cache.

R.



More information about the Gdb-patches mailing list