RFC: ARM simulator coredump
Richard Earnshaw
rearnsha@arm.com
Thu Jan 10 07:33:00 GMT 2002
> + int ok = state->CPRead[14] (state, 0, &cp14r0);
As a coding nit, I can't say I'm madly keen on a variable that's called
"ok". At any point other than its assignment, it isn't going to be very
clear what is "ok". This variable is used over more than 50 lines of code
which, at least for me, means that I won't be able to see the assignment
at the same time as it's final use.
R.
More information about the Gdb-patches
mailing list