RFA: Correct field names for class methods

[David Carlton]

In article <20020827031346.GA16591@nevyn.them.org>, Daniel Jacobowitz
<drow@mvista.com> writes:
 
> +void
> +update_method_name_from_physname (char **old_name, char *physname)
> +{
> +  char *method_name;
> +
> +  method_name = method_name_from_physname (physname);
> +
> +  if (method_name == NULL)
> +    error ("bad physname %s\n", physname);
> +
> +  if (strcmp (*old_name, method_name) != 0)
> +    *old_name = method_name;
> +  else
> +    xfree (method_name);
> +}

I'm pretty sure this is a memory leak.  How about replacing the last
if clause by

  xfree(*old_name);
  *old_name = method_name;

That should get rid of the memory leak and avoid a superfluous
strcmp.

(Also, the ChangeLog entry has the name of this function written
incorrectly.)

David Carlton
carlton@math.stanford.edu