[RFA] dwarf2read.c: set TYPE_DOMAIN_TYPE correctly for methods

Andrew Cagney ac131313@ges.redhat.com
Thu Aug 22 14:39:00 GMT 2002


> The ChangeLog need only state what changed, not why.
> 
> 
> Whoops, sorry about that.  How about this patch?

Like I said, it feels un-natural so it definitly takes getting 
accustomed to :-)  Anyway, the comment, yes like it.  In case you're 
wondering, the username/date convention came about because people 
realised they couldn't identify when they were reading 15(!?)  year old 
comments that described problems on systems that no longer exist!

As for the change proper, something for a debug info maintainer.

> By the way, am I correct in thinking that the ChangeLog is supposed
> to mention the PR number?  I noticed that GNATS picked up some of my
> earlier changes, and I'm assuming it noticed the PR number from the
> log message.

It's looking in the CVS commit message (which is typically a duplicate 
of the changelog anyway).  Hmm, this means that you've figured out that 
the best thing to stick in the CVS commit message is the changelog! :-)

enjoy,
Andrew




More information about the Gdb-patches mailing list