[RFA] cli/cli-dump.c: Write dump always in binary mode on Cygwin
Andrew Cagney
ac131313@ges.redhat.com
Wed Aug 7 10:55:00 GMT 2002
>>
>> On Mon, 5 Aug 2002, Michael Snyder wrote:
>>
>
>> > do we actually know of any environments
>> > where the #if is strictly necessary?
>
>>
>> Since GDB requires ISO C, and "wb" is part of the ISO C spec, I think we
>> can drop the #if. (Dependance on O_BINARY being defined is not very
>> clean anyway, IMHO, since O_BINARY does not belong to `fopen'.)
>>
>
>
> I don't think we can assume an ISO conforming C library.
True. However, I think we should at least start out with the assumption
that the above will work. We should wait until someone presents us with
hard evidence that there is a problem before hacking around it :-)
enjoy,
Andrew
More information about the Gdb-patches
mailing list