[PATCH] Trivial printf format warning fixes

Eli Zaretskii eliz@is.elta.co.il
Mon Apr 22 23:11:00 GMT 2002


On Mon, 22 Apr 2002, Jason R Thorpe wrote:

>                     error ("Syntax error at prompt position %d",
> -                          promptp - local_prompt);
> +                          (int) (promptp - local_prompt));
 
I think the result of subtracting two pointers can be wider than an int, 
can't it?  If so, casting to an int is not right, and the format should 
be changed to %ld.

(Yes, this is nitpicking, but if we are to fix this warning, might as 
well do it right ;-)



More information about the Gdb-patches mailing list