[rfa:sparc] Remove write_fp() from sparc-tdep.c

Andrew Cagney ac131313@cygnus.com
Fri Apr 5 16:05:00 GMT 2002


> On Apr 5,  5:04pm, Andrew Cagney wrote:
> 
> 
>> if (strcmp (target_shortname, "sim") != 0)
>> {
>> -      write_fp (old_sp);
>> -
>> +      if (gdbarch_tdep (current_gdbarch)->intreg_size == 8)
> 
> 
> How about
> 
> 	 if (GDB_TARGET_IS_SPARC64)

Didn't see it, I'll tweak it.

> instead?  (That matches the existing convention in the rest of the
> file better.)
> 
> Aside from that, I think your change is fine.  Something to consider
> though is whether the entire
> 
>     if (strcmp (target_shortname, "sim") != 0)
>       {
>         ...
>       }
> 
> could simply go away.  I.e, let the "sim" case just use the non-sim
> code.

Somebody elses problem - the only objective of this patch was to remove 
write_fp() :-)

thanks,
Andrew




More information about the Gdb-patches mailing list