[PATCH]: misc header file cleanup.
Thu Mar 1 13:43:00 GMT 2001
>>>>> "Michael" == Michael Elizabeth Chastain <email@example.com> writes:
Michael> Proofread, no problems found.
Michael> MIN_OF_TYPE is never used. MAX_OF_TYPE is used only in
Michael> m2-exp.y in some code that is #if 0'd out.
Correct. But had that code in m2-exp.y been enabled, the lack of
parens in MAX_OF_TYPE would have surprising results. In any case,
there is no harm to fix the macros now in case someone decides to
use them later.
I suspect there will be quite a few nits that linting will be turn up.
Some will be of this nature, where it's a "obviously correct" fix. I
suspect quite a few will highlight poor divisions of interface and
implementation (for example, declarations of functions in multiple
header files, etc.). And other things I choose to simple suppress
(fortunately, the lint I'm using has very finegrained control over
error message generation).
More information about the Gdb-patches