[rfa] signals 1/3 - move target_signal handling out of target.c

Andrew Cagney ac131313@cygnus.com
Wed Jul 18 14:16:00 GMT 2001


> I've also got a few small cleanups that can go in after the code moves (I
> want to keep them separate for revision history purposes).


Very wise move.


> 2001-07-18  Daniel Jacobowitz  <dan@debian.org>
> 
> * signals.c: New file.
> 	* target.c (struct signals): Move to signals.c.
> 	* target.c (target_signal_to_name): Likewise.
> 	* target.c (target_signal_from_name): Likewise.
> 	* target.c (target_signal_from_host): Likewise.
> 	* target.c (do_target_signal_to_host): Likewise.
> 	* target.c (target_signal_to_host_p): Likewise.
> 	* target.c (target_signal_to_host): Likewise.
> 	* target.c (target_signal_from_command): Likewise.
> 	* target.c (initialize_targets): Move check of
> 	struct signals to...
> 	* signals.c (_initialize_signals): Here.  New function.


No problems with the theory.  I just wonder about the file name.
A logical follow-on is to create ``signals.h'' (and put ``enum 
target_signal'' there).  Anyone know of a potential conflict?

If, in a later change there is going to be a 
s/target_signal/<something-sensible>/ should the file name reflect that 
intent.

enjoy,
	Andrew



More information about the Gdb-patches mailing list