[PATCH] muzzle a noisy warning in procfs

Michael Snyder msnyder@cygnus.com
Fri Jul 6 14:34:00 GMT 2001


I added this warning to procfs myself a couple years ago, as 
part of the general procfs rewrite.  It was just a paranoia
warning, and AFAIK it's never been triggered "in real life"
before now.  Unfortunately now it goes off all the time, because
of the change I recently made in resume().  Resume now calls
target_resume with a specific thread ID whenever it wants to
step over a breakpoint -- even when the program is not
multi-threaded.

So I'm just gonna take the warning out, as it is no longer
appropriate (it's no longer an error condition).
2001-07-06  Michael Snyder  <msnyder@redhat.com>

	* procfs.c (procfs_resume): Silence noisy warning.

Index: procfs.c
===================================================================
RCS file: /cvs/src/src/gdb/procfs.c,v
retrieving revision 1.30
diff -c -3 -p -r1.30 procfs.c
*** procfs.c	2001/05/15 00:03:36	1.30
--- procfs.c	2001/07/06 21:30:01
*************** procfs_resume (ptid_t ptid, int step, en
*** 4535,4544 ****
      {
        /* Resume a specific thread, presumably suppressing the others. */
        thread = find_procinfo (PIDGET (ptid), TIDGET (ptid));
!       if (thread == NULL)
! 	warning ("procfs: resume can't find thread %ld -- resuming all.",
! 		 TIDGET (ptid));
!       else
  	{
  	  if (thread->tid != 0)
  	    {
--- 4535,4541 ----
      {
        /* Resume a specific thread, presumably suppressing the others. */
        thread = find_procinfo (PIDGET (ptid), TIDGET (ptid));
!       if (thread != NULL)
  	{
  	  if (thread->tid != 0)
  	    {


More information about the Gdb-patches mailing list