[rfc] Move putchar_filtered() to utils.c

Andrew Cagney ac131313@cygnus.com
Tue Jan 30 18:35:00 GMT 2001


Fernando Nasser wrote:

> You just gave the argument.  We have hidden it in there so nobody would use
> it inside libgdb.  I agreed with Nick that was acceptable to use it inside
> the cli due to the current WIP state of things. He used it inside cli-regs.c

I don't know that I've provided an argument for putting
putchar_filtered() in the wrong place.  If a function is being added,
even as a tempoary hack, it really should be put in the correct place.

> W.r.t. the file, Nick actually created it to expedite things for me as I was
> planning to move a few cli utility functions there.  As I got caught up in some
> end of project affairs, I had to interrupt my CLI work and that is why the file
> is  so empty...

Yes.  We never know when we're going to be forced to drop the ball. 
Consequently it is best to always try to keep GDB in a consistent state.

> If you prefer, just delete it altogether.  Nick can add it as a static function
> to his cli-regs.c if that is really unavoidable and I can re-create the cli-utils
> files on my next round of CLI separation.

I'll move the function for the moment.  If someone does decide to
cleanup all the *_filtered() functions they are at least in the one
place.

I'll leave the cli-utils.[hc] as empty files.

	Andrew


More information about the Gdb-patches mailing list