RFA: correctly detect overlapping overlays
Jim Blandy
jimb@zwingli.cygnus.com
Mon Aug 13 07:39:00 GMT 2001
Andrew Cagney <ac131313@cygnus.com> writes:
> > + CORE_ADDR a_start = a->vma;
> > + CORE_ADDR a_end = a->vma + bfd_get_section_size_before_reloc (a);
> > + CORE_ADDR b_start = b->vma;
> > + CORE_ADDR b_end = b->vma + bfd_get_section_size_before_reloc (b);
>
>
> Jim, just a reminder on coding style.
> There isn't any reason to (and probably good reason to not) lay out the
> code so carefully. It just makes the task of someone running indent
> over the code all the more confusing.
I hadn't thought of people running indent. I'll fix that.
But I do think it's a shame. When layout can expose symmetry in what
you're doing, it makes it easier to read the code.
More information about the Gdb-patches
mailing list