[PATCH RFC] Protoize m32r-stub.c, m88k-nat.c, m88k-tdep.c
Kevin Buettner
kevinb@cygnus.com
Fri Sep 15 11:13:00 GMT 2000
On Sep 15, 10:50am, J.T. Conklin wrote:
> >>>>> "Kevin" == Kevin Buettner <kevinb@cygnus.com> writes:
> Kevin> I did three files this time because there was only one function that
> Kevin> needed doing in each of them. (The m88k-*.c files bring back old
> Kevin> memories; I first started hacking on gdb on an m88k box in the early
> Kevin> nineties.)
> Kevin>
> Kevin> * m32r-stub.c (prepare_to_step): Protoize.
>
> Should we consider not protoizing the *-stub.c files? While these are
> distributed with GDB, they are code that is going to be hacked to bits
> as they are integrated into a remote target. While user is probably
> using gcc, it may be reasonable to be as conservative we can when it
> comes to these files...
You're right. I think that Andrew (and perhaps others) warned me about
this too.
I hereby withdraw the m32r-stub.c portion of the patch.
Also, I will need to revert many of the changes that occurred in my
changes of 2000-07-29. Specifically, I'll need to revert the changes
that were made to the following files:
i386-stub.c
m32r-stub.c
m68k-stub.c
sh-stub.c
sparc-stub.c
sparcl-stub.c
sparclet-stub.c
I'll post a separate RFC for the reversion changes and wait a few days
for comments as usual.
Thanks for catching this.
Kevin
More information about the Gdb-patches
mailing list