[RFA] symtab.c: Another fix, now for gdb.c++/templates.exp regressions

[Daniel Berlin]

"Peter.Schauer" <Peter.Schauer@regent.e-technik.tu-muenchen.de> writes:

> On AIX and Digital Unix (and I suspect that this will happen on any non-elf
> target) I am observing the following regressions:
> 
> FAIL: gdb.c++/templates.exp: print Foo<volatile char *>::foo
> FAIL: gdb.c++/templates.exp: print Garply<Garply<char> >::garply
> FAIL: gdb.c++/templates.exp: break Garply<Garply<char> >::garply
> 
> It is caused by passing SYMBOL_NAME instead of SYMBOL_SOURCE_NAME to
> lookup_block_symbol, but lookup_block_symbol has been changed via the
> 2000-10-12 symtab.c patch to do a SYMBOL_SOURCE_NAME lookup (and by the way,
> the comments for lookup_block_symbol have _not_ been changed to reflect the
> new reality).
> Grepping through the GDB sources for all callers of lookup_block_symbol
> and making sure that they are not affected by the semantic change to
> lookup_block_symbol would have avoided the problem.
I tried to check all of the callers of lookup_* functions, but unfortunately,
a lot of these callers shouldn't be using them, and there are so many
callers I got lost.
They use them as optimizations, at the expense of breaking when you
make a change like I did.
I don't think that's right.
> And `maint check' on
> any C++ executable still remains an unresolved issue, but I am
> getting tired.