[PATCH RFC] Protoize remote-vx29k.c, remote.c, sol-thread.c
Kevin Buettner
kevinb@cygnus.com
Mon Oct 16 00:01:00 GMT 2000
More protoization...
The only thing mildly interesting in this one is remote_search(). At
first glance, it appears that it should have been protoized by the
fix-decls script. However, closer inspection reveals that it has a
syntax error which prevented the script from considering this function
for protoization. In the process of doing the hand protoization, I
fixed the syntax error, but I doubt anyone will notice since the code
in question is disabled via a ``#if 0'' construct anyway.
* remote-vx29k.c (vx29k_frame_chain_valid): Protoize.
* remote.c (remote_xfer_memory, remote_search): Protoize.
* sol-thread.c (sol_thread_xfer_memory): Protoize.
Index: remote-vx29k.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-vx29k.c,v
retrieving revision 1.3
diff -u -r1.3 remote-vx29k.c
--- remote-vx29k.c 2000/07/30 01:48:27 1.3
+++ remote-vx29k.c 2000/10/16 06:49:20
@@ -172,12 +172,10 @@
obtain the frame pointer (lr1) contents, we must add 4 bytes.
Note : may be we should modify init_frame_info() to get the frame pointer
and store it into the frame_info struct rather than reading its
- contents when FRAME_CHAIN_VALID is invoked. */
+ contents when FRAME_CHAIN_VALID is invoked. THISFRAME is unused. */
int
-vx29k_frame_chain_valid (chain, thisframe)
- CORE_ADDR chain;
- struct frame_info *thisframe; /* not used here */
+vx29k_frame_chain_valid (CORE_ADDR chain, struct frame_info *thisframe)
{
int fp_contents;
Index: remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.24
diff -u -r1.24 remote.c
--- remote.c 2000/10/13 21:41:21 1.24
+++ remote.c 2000/10/16 06:49:28
@@ -3546,16 +3546,12 @@
/* Read or write LEN bytes from inferior memory at MEMADDR,
transferring to or from debugger address BUFFER. Write to inferior if
SHOULD_WRITE is nonzero. Returns length of data written or read; 0
- for error. */
+ for error. TARGET is unused. */
/* ARGSUSED */
static int
-remote_xfer_memory (mem_addr, buffer, mem_len, should_write, target)
- CORE_ADDR mem_addr;
- char *buffer;
- int mem_len;
- int should_write;
- struct target_ops *target; /* ignored */
+remote_xfer_memory (CORE_ADDR mem_addr, char *buffer, int mem_len,
+ int should_write, struct target_ops *target)
{
CORE_ADDR targ_addr;
int targ_len;
@@ -3572,17 +3568,9 @@
/* Enable after 4.12. */
void
-remote_search (len, data, mask, startaddr, increment, lorange, hirange
- addr_found, data_found)
- int len;
- char *data;
- char *mask;
- CORE_ADDR startaddr;
- int increment;
- CORE_ADDR lorange;
- CORE_ADDR hirange;
- CORE_ADDR *addr_found;
- char *data_found;
+remote_search (int len, char *data, char *mask, CORE_ADDR startaddr,
+ int increment, CORE_ADDR lorange, CORE_ADDR hirange,
+ CORE_ADDR *addr_found, char *data_found)
{
if (increment == -4 && len == 4)
{
Index: sol-thread.c
===================================================================
RCS file: /cvs/src/src/gdb/sol-thread.c,v
retrieving revision 1.17
diff -u -r1.17 sol-thread.c
--- sol-thread.c 2000/09/28 07:53:41 1.17
+++ sol-thread.c 2000/10/16 06:49:30
@@ -754,13 +754,15 @@
procfs_ops.to_prepare_to_store ();
}
+/* Transfer LEN bytes between GDB address MYADDR and target address
+ MEMADDR. If DOWRITE is non-zero, transfer them to the target,
+ otherwise transfer them from the target. TARGET is unused.
+
+ Returns the number of bytes transferred. */
+
static int
-sol_thread_xfer_memory (memaddr, myaddr, len, dowrite, target)
- CORE_ADDR memaddr;
- char *myaddr;
- int len;
- int dowrite;
- struct target_ops *target; /* ignored */
+sol_thread_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, int dowrite,
+ struct target_ops *target)
{
int retval;
struct cleanup *old_chain;
More information about the Gdb-patches
mailing list