[RFA] trace_find_tracepoint_command bug fix

David Taylor taylor@cygnus.com
Wed Nov 15 12:40:00 GMT 2000


    Date: Wed, 15 Nov 2000 12:18:36 -0800
    From: Michael Snyder <msnyder@redhat.com>

    David Taylor wrote:
    > 
    > In trace_find_tracepoint_command (tracepoint.c), we find the line:
    > 
    >         tdp = parse_and_eval_address (args);
    > 
    > Since the tdp is just an integer, I'd like to change that to instead
    > read:
    > 
    >         tdp = parse_and_eval_long (args);
    > 
    > The ChangeLog entry would be:
    > 
    >         * tracepoint.c (trace_find_tracepoint_command): Replace call to
    >         parse_and_eval_address with a call to parse_and_eval_long as
    >         we are evaluating an integer, not an address.

    Yup, please go ahead.  Actually, I thought you'd 
    already done this.  Is this one that got away the first time?

Thanks.

I did a bunch of these.  I wasn't sure that I had found them all, and
I suspected that I had missed some.

I was under pressure to fix another problem which the address vs
integer confusion was making more difficult to debug... so, I fixed
several of them, but acknowledged that I had probably missed some.

I haven't done any in the architecture dependent files.


More information about the Gdb-patches mailing list