[PATCH]: Promote float args on i386 (attn Hurd, Cygwin, DJGPP...)

Michael Snyder msnyder@cygnus.com
Fri May 12 12:36:00 GMT 2000


Kevin Buettner wrote:
> 
> On May 12, 10:26am, Michael Snyder wrote:
> 
> > Mark Kettenis wrote:
> >
> > >    Sure.
> > >    make check RUNTESTFLAGS=callfuncs.exp
> > >    FAIL: gdb.base/callfuncs.exp: p t_float_values(3.14159,-2.3765)
> > >    FAIL: gdb.base/callfuncs.exp: p t_float_values(float_val1,float_val2)
> > >    FAIL: gdb.base/callfuncs.exp: p t_float_values(3.14159,float_val2)
> > >    FAIL: gdb.base/callfuncs.exp: p t_float_values(float_val1,-2.3765)
> > >    FAIL: gdb.base/callfuncs.exp: p t_float_values2(3.14159,float_val2)
> > >
> > > I don't see those failures on Linux.
> >
> > Really???  I do!  I wonder whether it's a Linux version diff,
> > or a compiler diff.  What versions are you using?  Mine are:
> >
> > %] msnyder<12>% gcc -v
> > Reading specs from
> > /usr/progressive/bin/../lib/gcc-lib/i386-pc-linux-gnu/2.9-gnu
> > pro-98r1/specs
> > gcc version 2.9-gnupro-98r1
> > %] msnyder<14>% uname -a
> > Linux happy.cygnus.com 2.2.14-5.0smp #1 SMP Tue Mar 7 21:01:40 EST 2000
> > i686 unknown
> 
> FWIW, on my Linux box, I don't see the callfuncs.exp failures that you
> mention either.  This is without your proposed patches.  Here's the
> version info on my system...

Well, curiouser and curiouser... I just checked a variety of
Linux boxes inhouse, with Redhat versions ranging from 5.0 to
6.2... As long as I use /usr/bin/gcc, I always get the PUSHL
assembly code rather than the SUBL/FSTPS code that Mark got.

I'll obviously withdraw the patch, since I don't want to break
any systems that are working correctly -- we'll have to figure
out how to distinguish which systems pass floats and which pass
doubles.

Michael


More information about the Gdb-patches mailing list