gdb spelling corrections patches
Jim Blandy
jimb@zwingli.cygnus.com
Thu Jun 8 14:34:00 GMT 2000
We're definately interested in this. *ahem*
David, you haven't signed a copyright agreement, right? What is the
sense of the jury about the copyright status of a change like this?
The overall patch will be quite large, but there's no individual
change longer than a line or two, and it's hard to argue that it's one
coherent work. I tend to think it's not copyrightable.
Anyway, once the copyright issues have been cleared away, I think it
would be fine to submit just one huge patch.
davea@quasar.engr.sgi.com (David B Anderson) writes:
>
>
> I've never submitted a patch before, so bear with me.
>
> I've noted a number of mispellings in comments in gdb.
> (ignoring duplicates, perhaps 40 or so).
>
> I only show a few diffs here, against top-of-trunk gdb.
> (the dependance (correct is dependence) spelling
> confusion appears in a number of files, BTW)
>
> If these patches are acceptable I will submit others.
>
> Is there a preference for large batches or small ones?
> That is, is fixing all in one long set of patches
> or fixing just a 'reasonable set' per submission the better
> approach?
>
> Would folks rather not hear about these spelling mistakes?
> (perhaps this is an old issue)
>
> Guidance would be welcome.
>
> Regards,
> David B. Anderson davea@sgi.com danderson@acm.org http://reality.sgi.com/davea/
>
> Index: dst.h
> ===================================================================
> RCS file: /xlv2/davea/sourceware/src/gdb/dst.h,v
> retrieving revision 1.1.1.2
> diff -c -r1.1.1.2 dst.h
> *** dst.h 1999/07/07 20:05:39 1.1.1.2
> --- dst.h 2000/06/08 20:20:45
> ***************
> *** 541,547 ****
> }
> dst_var_loc_t;
>
> ! /* Locations come in two versions. The sort, and the long. The difference
> * between the short and the long is the addition of a statement number
> * field to the start andend of the range of the long, and and unkown
> * purpose field in the middle. Also, loc_type and loc_index aren't
> --- 541,547 ----
> }
> dst_var_loc_t;
>
> ! /* Locations come in two versions. The short, and the long. The difference
> * between the short and the long is the addition of a statement number
> * field to the start andend of the range of the long, and and unkown
> * purpose field in the middle. Also, loc_type and loc_index aren't
> Index: dbxread.c
> ===================================================================
> RCS file: /xlv2/davea/sourceware/src/gdb/dbxread.c,v
> retrieving revision 1.6
> diff -c -r1.6 dbxread.c
> *** dbxread.c 2000/06/04 00:41:09 1.6
> --- dbxread.c 2000/06/08 20:20:30
> ***************
> *** 805,816 ****
> /* sym and stabsstring for continuing information in cfront */
> struct symbol *sym;
> char *stabs;
> ! /* state dependancies (statics that must be preserved) */
> int sym_idx;
> int sym_end;
> int symnum;
> int (*func) (struct objfile *, struct symbol *, char *);
> ! /* other state dependancies include:
> (assumption is that these will not change since process_now FIXME!!)
> stringtab_global
> n_stabs
> --- 805,816 ----
> /* sym and stabsstring for continuing information in cfront */
> struct symbol *sym;
> char *stabs;
> ! /* state dependencies (statics that must be preserved) */
> int sym_idx;
> int sym_end;
> int symnum;
> int (*func) (struct objfile *, struct symbol *, char *);
> ! /* other state dependencies include:
> (assumption is that these will not change since process_now FIXME!!)
> stringtab_global
> n_stabs
> ***************
> *** 1878,1884 ****
>
> pst->symtab = end_symtab (text_offset + text_size, objfile, SECT_OFF_TEXT (objfile));
>
> ! /* Process items which we had to "process_later" due to dependancies
> on other stabs. */
> process_now (objfile);
>
> --- 1878,1884 ----
>
> pst->symtab = end_symtab (text_offset + text_size, objfile, SECT_OFF_TEXT (objfile));
>
> ! /* Process items which we had to "process_later" due to dependencies
> on other stabs. */
> process_now (objfile);
>
> Index: cp-valprint.c
> ===================================================================
> RCS file: /xlv2/davea/sourceware/src/gdb/cp-valprint.c,v
> retrieving revision 1.3
> diff -c -r1.3 cp-valprint.c
> *** cp-valprint.c 2000/05/28 01:12:26 1.3
> --- cp-valprint.c 2000/06/08 20:18:43
> ***************
> *** 472,478 ****
> } /* non-RRBC case */
> else
> {
> ! /* FIXME -- seem comments above */
> /* RRBC support present; function pointers are found
> * by indirection through the class segment entries. */
>
> --- 472,478 ----
> } /* non-RRBC case */
> else
> {
> ! /* FIXME -- see comments above */
> /* RRBC support present; function pointers are found
> * by indirection through the class segment entries. */
>
> Index: corelow.c
> ===================================================================
> RCS file: /xlv2/davea/sourceware/src/gdb/corelow.c,v
> retrieving revision 1.6
> diff -c -r1.6 corelow.c
> *** corelow.c 2000/06/04 01:58:49 1.6
> --- corelow.c 2000/06/08 20:18:18
> ***************
> *** 108,114 ****
>
> /* Walk through the list of core functions to find a set that can
> handle the core file open on ABFD. Default to the first one in the
> ! list of nothing matches. Returns pointer to set that is
> selected. */
>
> static struct core_fns *
> --- 108,114 ----
>
> /* Walk through the list of core functions to find a set that can
> handle the core file open on ABFD. Default to the first one in the
> ! list if nothing matches. Returns pointer to set that is
> selected. */
>
> static struct core_fns *
> Index: tracepoint.h
> ===================================================================
> RCS file: /xlv2/davea/sourceware/src/gdb/tracepoint.h,v
> retrieving revision 1.3
> diff -c -r1.3 tracepoint.h
> *** tracepoint.h 2000/06/04 00:41:09 1.3
> --- tracepoint.h 2000/06/08 20:18:01
> ***************
> *** 107,113 ****
> };
>
>
> ! /* The tracepont chain of all tracepoints */
>
> extern struct tracepoint *tracepoint_chain;
>
> --- 107,113 ----
> };
>
>
> ! /* The tracepoint chain of all tracepoints */
>
> extern struct tracepoint *tracepoint_chain;
>
>
More information about the Gdb-patches
mailing list