RFA: Testsuite patches...
Scott Bambrough
scottb@netwinder.org
Fri Jul 28 12:03:00 GMT 2000
Michael Snyder wrote:
>
> I don't see any reference to the string "Pid" in environ.exp,
> and the references to "process" are not testing the output
> that you changed. Why do you want this change?
Because the output generated by gdb uses pid_to_str which eventually resolves to
the function I have changed. environ.exp expects process instead of Pid. HP
has its own version of pid_to_str which uses process as well. Basically this
change allows the last test in environ.exp to succeed on ARM and x86 Linux.
These are the only systems I have available ATM.
> > Change capitalization on "Thread" for consistency.
>
> Consistency with what? I'm not strongly opposed, but since
> SOMEONE may depend on this output, I'd like to know the
> motivation for changing it.
child_pid_to_str in hppa-nat.c returns either "process pid"
child_pid_to_str in inftarg.c returns either "thread tid" or "process pid"
child_pid_to_str in lynx-nat.c returns either "process pid thread tid" or
"process pid"
normal_pid_to_str returns either "thread pid" or "process pid"
linuxthreads_pid_to_str returns "Thread tid", "Pid pid", my changes makes this
"thread tid", "process pid"
cygwin_pid_to_str returns "thread tid.pid" or "process pid"
gnu_pid_to_str returns "thread pid.tid" or "process pid"
hpux_pid_to_str returns "Thread tid"
procfs_pid_to_str returns "LWP tid", "Process pid"
uw_thread_pid_to_str returns "LWP tid", "Process pid", "Thread tid"
solaris_pid_to_str returns "Thread tid (LWP lwpid)", "Thread tid (defunct)",
"LWP lwpid", "Thread tid", "process pid"
thread_db_pid_to_str returns "Thread tid (LWP lwpid)", "Thread tid (state str)",
"LWP lwpid", "thread tid", "process pid"
There is not a whole lot of consistency, but I thought it was more more
consistent on the whole with other functions that returned "thread id", "process
id". Matter of personal opinion I guess.
--
Scott Bambrough - Software Engineer
REBEL.COM http://www.rebel.com
NetWinder http://www.netwinder.org
More information about the Gdb-patches
mailing list