Patch: `make tags' -vs- gdbtk, try 2
Andrew Cagney
ac131313@cygnus.com
Sat Dec 2 17:20:00 GMT 2000
Tom Tromey wrote:
>
> I first submitted this patch on November 21. This resubmission
> refines the patch to correctly find the gdbtk `.h' files and to
> correctly make tags for gdbtk hooks. If gdbtk isn't checked out, it
> should have no effect.
>
> Is this ok to commit?
Tom,
Should the logic be reversed - don't do anything special for gdbtk?
Perhaphs make a list of directories to exclude (just testsuite?) rather
than have to explicitly list the directories to include. That way this
code won't need hacking everytime someone adds a new directory.
Andrew
> In general how long should I wait before pinging about a patch? In
> this case I figured 10 days was long enough for a relatively simple
> Makefile patch.
>
> 2000-12-02 Tom Tromey <tromey@redhat.com>
>
> * Makefile.in (TAGS): Correctly find gdbtk .c/.h files. Also,
> generate tags for gdbtk Tcl sources.
>
> Tom
>
> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/Makefile.in,v
> retrieving revision 1.47
> diff -u -r1.47 Makefile.in
> --- Makefile.in 2000/11/10 23:02:56 1.47
> +++ Makefile.in 2000/12/02 18:58:11
> @@ -871,11 +871,18 @@
> $(srcdir)/$(XM_FILE) \
> $(srcdir)/$(NAT_FILE) \
> `(for i in $(DEPFILES) $(TAGFILES_NO_SRCDIR); do \
> - echo $(srcdir)/$$i ; \
> + case "$$i" in \
> + gdbtk*) ;; \
> + *) echo $(srcdir)/$$i ;; \
> + esac; \
> done ; for i in $(TAGFILES_WITH_SRCDIR); do \
> echo $$i ; \
> done) | sed -e 's/\.o$$/\.c/'` \
> - `find $(srcdir)/config -name '*.h' -print`
> + `find $(srcdir)/config -name '*.h' -print` \
> + `find $(srcdir)/gdbtk -name '*.[ch]' -print` \
> + --lang=none \
> + --regex='/[ \t]*\(proc\|method\|itcl_class\|body\|define_hook\)[ \t]+\([^ \t]+\)/\1/' \
> + `find $(srcdir)/gdbtk \( -name '*.tcl' -o -name '*.ith' -o -name '*.itb' \) -print`
>
> tags: TAGS
>
More information about the Gdb-patches
mailing list