RFC: changes to configure.in and configure

Scott Bambrough scottb@netwinder.org
Tue Aug 1 07:38:00 GMT 2000


Andrew Cagney wrote:
> 
> I'm not sure how this patch:
> 
> -# else
> +else
>  # GDBserver is only useful in a "native" enviroment
> -# configdirs=`echo $configdirs | sed 's/gdbserver//'`
> +configdirs=`echo $configdirs | sed 's/gdbserver//'`
>  fi
>  changequote([,])

This bit of the patch removes gdbserver from $configdirs unless it is a native
build.

> +SUBDIRS="doc testsuite nlm $configdirs"
> +if test "${enable_multi_ice}" = "yes"; then
> +  SUBDIRS="${SUBDIRS} multi-ice"
> +fi
> +
> +AC_SUBST(SUBDIRS)
> changes things. Hmmmmm, ah this bit:
> 
> has something to do with it - be careful to not re-order code
> unnecessarily - it can hide real changes.

Yes, this is the effective part of the change.  I didn't reorder the code
unnecessarily.  This was all together in configure.in until someone added code
in between, the day before I submitted my patch.  I wonder who that was :) ?

>         o       not build gdbserver
>                 (suprize!)
> 
>         o       always configure GDBSERVER
>                 (when selected)
> 
> Your change would completly reverse this.  I don't know that that was
> the intention.

It doesn't happen.  gdbserver never gets configured without explicitly going
into the directory and configuring.  AFAIK, a target maintainer can select
gdbserver by modifying $configdirs in configure.tgt.  It can also add other
directories to configure.  This seems to be the way gdbserver is selected and
built.  It is also the way the arm embedded targets select rdi-share to be
configured and the netware targets select nlm to be configured.  Whoever made
this change broke this mechanism, while trying to prevent gdbserver from being
built.

It would be better to add --enable-gdbserver and --disable-gdbserver flags IMHO
if you wanted to selectively build gdbserver.  What do you think?

Scott

-- 
Scott Bambrough - Software Engineer
REBEL.COM    http://www.rebel.com
NetWinder    http://www.netwinder.org


More information about the Gdb-patches mailing list