[Fwd: Re: [RFA] Don't talk about ptrace when there's none]

[Michael Snyder]

To : Eli Zaretskii <eliz at is dot elta dot co dot il>
Subject : Re: [RFA] Don't talk about ptrace when there's none
>From : Michael Snyder <msnyder at cygnus dot com>
Date : Wed, 12 Apr 2000 09:20:09 -0700
Organization : Cygnus Solutions
References : < 200004061216.IAA21692@mescaline.gnu.org >	< ya6r8kms.fsf@dan.resnet.rochester.edu >	< 200004061419.KAA19077@indy.delorie.com >	< 20000406113658.D14700@cygnus.com >	< 14572.46947.244151.364066@kwikemart.cygnus.com >	< 38ECC0C4.4D2C@cygnus.com > < 200004091358.JAA01430@indy.delorie.com > < 200004091445.e39EjNC00395@delius.kettenis.local > < 200004120827.EAA05118@indy.delorie.com >
Reply-To : msnyder at cygnus dot com

Eli Zaretskii wrote:

> Okay, then how about the following patch?  Good enough to commit?

OK, great.

Michael

> 2000-04-11  Eli Zaretskii  <eliz@is.elta.co.il>
> 
>         * infrun.c (proceed, normal_stop): Change the error message about
>         failure to insert breakpoints/watchpoints so that it makes sense
>         even if ptrace is not used or no other processes can be active.
> 
> --- gdb/infrun.c~1      Sat Apr  1 19:41:12 2000
> +++ gdb/infrun.c        Tue Apr 11 19:37:02 2000
> @@ -1044,9 +1044,11 @@ proceed (CORE_ADDR addr, enum target_sig
>        int temp = insert_breakpoints ();
>        if (temp)
>         {
> -         print_sys_errmsg ("ptrace", temp);
> +         print_sys_errmsg ("insert_breakpoints", temp);
>           error ("Cannot insert breakpoints.\n\
> -The same program may be running in another process.");
> +The same program may be running in another process,\n\
> +or you may have requested too many hardware\n\
> +breakpoints and/or watchpoints.\n");
>         }
> 
>        breakpoints_inserted = 1;
> @@ -3384,9 +3386,11 @@ normal_stop (void)
>    if (breakpoints_failed)
>      {
>        target_terminal_ours_for_output ();
> -      print_sys_errmsg ("ptrace", breakpoints_failed);
> +      print_sys_errmsg ("While inserting breakpoints", breakpoints_failed);
>        printf_filtered ("Stopped; cannot insert breakpoints.\n\
> -The same program may be running in another process.\n");
> +The same program may be running in another process,\n\
> +or you may have requested too many hardware breakpoints\n\
> +and/or watchpoints.\n");
>      }
> 
>    if (target_has_execution && breakpoints_inserted)