PATCH/RFA : copying.c & copying.txt

Andrew Cagney ac131313@cygnus.com
Mon Apr 10 04:56:00 GMT 2000


Philippe De Muyter wrote:
> 
> Do you already know that Eli's recent copying.txt change causes build failure
> for gdb ?

Hmm, it is make dependant. GNU make finds copying.c in the src directory
and just uses that.
This also suggests what I suspect is the correct solution - copying.c
should only be dependant on COPYING when ``maintainer-mode'' is enabled.

	Andrew

> The Makefile contains :
> 
>     # When DJGPP Make runs on MS-DOS, it downcases all file names, so
>     # it doesn't find COPYING, and wants to make it...
>     copying.txt:
>             test -f copying.txt || \
>               (test "$$LN_S" = "ln -s" && \
>                 ln -s $(srcdir)/COPYING copying.txt;) || \
>               cp -p $(srcdir)/COPYING copying.txt 2>/dev/null || \
>               ln $(srcdir)/COPYING copying.txt 2>/dev/null || \
>               cp $(srcdir)/COPYING copying.txt
> 
>     # Make copying.c from COPYING
>     copying.c: copying.txt copying.awk
>             awk -f $(srcdir)/copying.awk < $(srcdir)/copying.txt > copying.c
> 
> We create copying.txt in the current directory, but we use the one in $(srcdir).
> That can not work when building in a separate directory.
> 
> The patch below fixes that. OK to commit ?
> 
> Philippe De Muyter  <phdm@macqel.be>
> 
>         * Makefile.in (copying.c): Build from `copying.txt', not
>         `$(srcdir)/copying.txt'.
> 
> Index: gdb/Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/Makefile.in,v
> retrieving revision 1.25
> diff -u -p -r1.25 Makefile.in
> --- Makefile.in 2000/04/09 14:37:28     1.25
> +++ Makefile.in 2000/04/10 10:14:38
> @@ -954,7 +954,7 @@ copying.txt:
> 
>  # Make copying.c from COPYING
>  copying.c: copying.txt copying.awk
> -       awk -f $(srcdir)/copying.awk < $(srcdir)/copying.txt > copying.c
> +       awk -f $(srcdir)/copying.awk < copying.txt > copying.c
> 
>  version.c: Makefile
>         rm -f version.c


More information about the Gdb-patches mailing list