(patch) hpjyg22: misc. 32x64 and minor changes

Andrew Cagney ac131313@cygnus.com
Mon Nov 15 17:52:00 GMT 1999


Jimmy Guo wrote:
> 
> This patch contains some 32x64 fixes and minor changes.  See ChangeLog:
> 
> 1999-11-11      Jimmy Guo       <guo@cup.hp.com>
> 
>         * solib.c,osfsolib.c,irix5-nat.c: Change error string from
>           'No exec file' to 'No executable file'.
> 
>         * solib.c (info_sharedlibrary_command): 32x64 fix.
> 
>         * m2-exp.y (lex): add default case statement to capture
>         unhandled token and call error().

> ***************
> *** 1301,1312 ****
>               header_done++;
>             }
> 
> !         printf_unfiltered ("%-*s", addr_width,
> !                     local_hex_string_custom ((unsigned long) LM_ADDR (so),
> !                                              addr_fmt));
> !         printf_unfiltered ("%-*s", addr_width,
> !                        local_hex_string_custom ((unsigned long) so->lmend,
> !                                                 addr_fmt));
>           printf_unfiltered ("%-12s", so->symbols_loaded ? "Yes" : "No");
>           printf_unfiltered ("%s\n", so->so_name);
>         }
> --- 1301,1312 ----
>               header_done++;
>             }
> 
> !         printf_unfiltered ("%-12s",
> !                     longest_local_hex_string_custom ((LONGEST) LM_ADDR (so),
> !                                              "08l"));
> !         printf_unfiltered ("%-12s",
> !                        longest_local_hex_string_custom ((LONGEST) so->lmend,
> !                                                 "08l"));
>           printf_unfiltered ("%-12s", so->symbols_loaded ? "Yes" : "No");
>           printf_unfiltered ("%s\n", so->so_name);
>         }

FYI,  I'm not sure about this.  Hardwiring ``08l'' looks dangerous.

Perhaps paddr() should be used - that returns a string based on
TARGET_PTR_BIT.  Hmm, here thougy, you're manipulating values from the
ELF object file format )??).  Perhaphs something object-file related is
needed?  Also, there are at least systems with elf32 object files but
TARGET_PTR_BIT=64.

Hmm, to step back, I'm not sure what the problem that has occured is. 
Could you please expand a little.

	best regards,
		Andrew


More information about the Gdb-patches mailing list