[binutils-gdb] Constify coffread.c:getsymname

Tom Tromey tromey@sourceware.org
Tue Jan 20 15:52:17 GMT 2026


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=363ff43b4bbb8efd112c44ef93a6d2b284f1f2bf

commit 363ff43b4bbb8efd112c44ef93a6d2b284f1f2bf
Author: Tom Tromey <tromey@adacore.com>
Date:   Fri Jan 16 10:59:08 2026 -0700

    Constify coffread.c:getsymname
    
    I noticed that the symbol name in coffread.c can be const.
    
    Approved-By: Simon Marchi <simon.marchi@efficios.com>

Diff:
---
 gdb/coffread.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gdb/coffread.c b/gdb/coffread.c
index 18641aafd18..dc5550af4a2 100644
--- a/gdb/coffread.c
+++ b/gdb/coffread.c
@@ -71,7 +71,7 @@ static int pe_file;
 
 struct coff_symbol
   {
-    char *c_name;
+    const char *c_name;
     int c_naux;			/* 0 if syment only, 1 if syment +
 				   auxent, etc.  */
     CORE_ADDR c_value;
@@ -86,7 +86,7 @@ static long stringtab_length = 0;
 /* Used when reading coff symbols.  */
 static int symnum;
 
-static char *getsymname (struct internal_syment *);
+static const char *getsymname (struct internal_syment *);
 
 static int init_stringtab (bfd *, file_ptr, gdb::unique_xmalloc_ptr<char> *);
 
@@ -636,11 +636,11 @@ init_stringtab (bfd *abfd, file_ptr offset, gdb::unique_xmalloc_ptr<char> *stora
   return 0;
 }
 
-static char *
+static const char *
 getsymname (struct internal_syment *symbol_entry)
 {
   static char buffer[SYMNMLEN + 1];
-  char *result;
+  const char *result;
 
   if (symbol_entry->_n._n_n._n_zeroes == 0)
     {


More information about the Gdb-cvs mailing list