[binutils-gdb] [gdb/testsuite, tclint] Fix gdb.rocm

Tom de Vries vries@sourceware.org
Fri Sep 12 13:05:03 GMT 2025


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=684ae4e83d1d2fa40742541478fe15363f264a82

commit 684ae4e83d1d2fa40742541478fe15363f264a82
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Sep 12 15:04:50 2025 +0200

    [gdb/testsuite, tclint] Fix gdb.rocm
    
    Running tclint on the test-cases in gdb.rocm shows a few problems:
    ...
    precise-memory-multi-inferiors.exp:33:5: expected braced word or word \
      without substitutions in argument interpreted as expr [command-args]
    precise-memory-multi-inferiors.exp:43:5: expected braced word or word \
      without substitutions in argument interpreted as expr [command-args]
    precise-memory-multi-inferiors.exp:55:5: expected braced word or word \
      without substitutions in argument interpreted as expr [command-args]
    ...
    
    Fix these.
    
    The gdb.rocm test-cases are unsupported for me, so I can't test this.

Diff:
---
 gdb/testsuite/gdb.rocm/precise-memory-multi-inferiors.exp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.rocm/precise-memory-multi-inferiors.exp b/gdb/testsuite/gdb.rocm/precise-memory-multi-inferiors.exp
index c7a78b87d51..058b085ab47 100644
--- a/gdb/testsuite/gdb.rocm/precise-memory-multi-inferiors.exp
+++ b/gdb/testsuite/gdb.rocm/precise-memory-multi-inferiors.exp
@@ -30,7 +30,7 @@ proc test_per_inferior { } {
     gdb_test "show amdgpu precise-memory" \
 	"AMDGPU precise memory access reporting is off \\(currently disabled\\)." \
 	"show initial value, inferior 1"
-    if $::test_python {
+    if { $::test_python } {
 	gdb_test "python print(gdb.parameter(\"amdgpu precise-memory\"))" \
 	    "False" \
 	    "show initial value using Python, inferior 1"
@@ -40,7 +40,7 @@ proc test_per_inferior { } {
     gdb_test "show amdgpu precise-memory" \
 	"AMDGPU precise memory access reporting is on \\(currently disabled\\)." \
 	"show new value, inferior 1"
-    if $::test_python {
+    if { $::test_python } {
 	gdb_test "python print(gdb.parameter(\"amdgpu precise-memory\"))" \
 	    "True" \
 	    "show new value using Python, inferior 1"
@@ -52,7 +52,7 @@ proc test_per_inferior { } {
     gdb_test "show amdgpu precise-memory" \
 	"AMDGPU precise memory access reporting is off \\(currently disabled\\)." \
 	"show initial value, inferior 2"
-    if $::test_python {
+    if { $::test_python } {
 	gdb_test "python print(gdb.parameter(\"amdgpu precise-memory\"))" \
 	    "False" \
 	    "show initial value using Python, inferior 2"


More information about the Gdb-cvs mailing list