[binutils-gdb] [gdb/testsuite, tclint] Fix lib/selftest-support.exp

Tom de Vries vries@sourceware.org
Sun Oct 5 20:51:46 GMT 2025


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f24a56970ba7d4441854d8585efc5a75ba16dc14

commit f24a56970ba7d4441854d8585efc5a75ba16dc14
Author: Tom de Vries <tdevries@suse.de>
Date:   Sun Oct 5 22:50:09 2025 +0200

    [gdb/testsuite, tclint] Fix lib/selftest-support.exp

Diff:
---
 gdb/tclint.toml                        | 1 -
 gdb/testsuite/lib/selftest-support.exp | 8 ++++----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/gdb/tclint.toml b/gdb/tclint.toml
index d177891e476..4a77ce9ad89 100644
--- a/gdb/tclint.toml
+++ b/gdb/tclint.toml
@@ -44,7 +44,6 @@ exclude = [
 "gdb/testsuite/lib/pascal.exp",
 "gdb/testsuite/lib/perftest.exp",
 "gdb/testsuite/lib/prelink-support.exp",
-"gdb/testsuite/lib/selftest-support.exp",
 "gdb/testsuite/lib/trace-support.exp",
 # IGNORE (document reason in trailing comment):
 "gdb/testsuite/gdb.stabs", # To be removed.
diff --git a/gdb/testsuite/lib/selftest-support.exp b/gdb/testsuite/lib/selftest-support.exp
index af8ec6fb982..d0905eb20f2 100644
--- a/gdb/testsuite/lib/selftest-support.exp
+++ b/gdb/testsuite/lib/selftest-support.exp
@@ -64,11 +64,11 @@ proc _selftest_has_libtool {} {
 # wrapper.
 
 proc selftest_libtool_get_real_gdb_executable { executable } {
-    if [_selftest_gdb_is_installed] {
+    if {[_selftest_gdb_is_installed]} {
 	return $executable
     }
 
-    if ![_selftest_has_libtool] {
+    if {![_selftest_has_libtool]} {
 	return $executable
     }
 
@@ -206,14 +206,14 @@ proc selftest_prepare {} {
 
     # ... or seemingly testing with a cross debugger?  Likely GDB
     # wouldn't be able to debug itself then...
-    if ![isnative] {
+    if {![isnative]} {
 	return
     }
 
     # ... or with a stub-like server?  I.e., gdbserver + "target
     # remote"?  In that case we won't be able to pass command line
     # arguments to GDB, and _selftest_setup wants to do exactly that.
-    if [use_gdb_stub] {
+    if {[use_gdb_stub]} {
 	return
     }


More information about the Gdb-cvs mailing list