[binutils-gdb] [gdb/testsuite] Fix DUPLICATE in callfuncs.exp

Tom de Vries vries@sourceware.org
Thu Nov 6 09:39:38 GMT 2025


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=792beba6ac48caa9d09470584cc4d9ddd023a96e

commit 792beba6ac48caa9d09470584cc4d9ddd023a96e
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Nov 6 10:39:33 2025 +0100

    [gdb/testsuite] Fix DUPLICATE in callfuncs.exp
    
    With test-case gdb.base/callfuncs.exp I get:
    ...
    UNTESTED: gdb.base/callfuncs.exp: failed to prepare
      ...
    UNTESTED: gdb.base/callfuncs.exp: failed to prepare
    DUPLICATE: gdb.base/callfuncs.exp: failed to prepare
    ...
    
    Fix this by moving a with_test_prefix up one level.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.base/callfuncs.exp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.base/callfuncs.exp b/gdb/testsuite/gdb.base/callfuncs.exp
index 59306d47a4e..d4a53e803c6 100644
--- a/gdb/testsuite/gdb.base/callfuncs.exp
+++ b/gdb/testsuite/gdb.base/callfuncs.exp
@@ -541,8 +541,9 @@ if { ![prepare_for_testing "failed to prepare" $testfile $srcfile "$compile_flag
     perform_all_tests 1
 }
 
-if { ![prepare_for_testing "failed to prepare" $testfile $srcfile "$compile_flags additional_flags=-DNO_PROTOTYPES"] } {
-    with_test_prefix "noproto" {
+with_test_prefix "noproto" {
+    if { ![prepare_for_testing "failed to prepare" $testfile $srcfile \
+	       "$compile_flags additional_flags=-DNO_PROTOTYPES"] } {
 	perform_all_tests 0
     }
 }


More information about the Gdb-cvs mailing list